Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/pulseaudio:dbus-support into ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Merged at revision: ba7c14170389c7f5cfef072ae018f55171675295
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/pulseaudio:dbus-support
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/pulseaudio:master
Diff against target: 57 lines (+11/-14)
1 file modified
snapcraft.yaml (+11/-14)
Reviewer Review Type Date Requested Status
System Enablement Bot continuous-integration Needs Fixing
Review via email: mp+387586@code.launchpad.net

Commit message

Add additional plugs to support ALSA fully
Enable dbus and add bluez plug
Move to audio-playback, audio-record interfaces instead of pulseaudio

Description of the change

Add additional plugs to support ALSA fully
Enable dbus and add bluez plug
Move to audio-playback, audio-record interfaces instead of pulseaudio

To post a comment you must log in.
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

This snapd MP needs to be merged & released before merging this one:

https://github.com/snapcore/snapd/pull/9031

Also, auto-connect for the new interfaces would need to be set-up in the brand store.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: afd9a476ab34eacb450ded5df6e9b95d9a4b00ab

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1348/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

PASSED: Successfully build documentation, rev: 47d61045c73d554f9123fa289a1d2e1479e2ee63

Generated documentation is available at https://jenkins.canonical.com/system-enablement/job/snappy-hwe-snaps-snap-docs/1349/

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 34e50a4..35db317 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -16,33 +16,31 @@ apps:
6 pulseaudio:
7 command: bin/pulseaudio
8 daemon: simple
9- plugs: [network, network-bind]
10- slots: [service]
11+ plugs: [network, network-bind, bluez, hardware-observe, alsa]
12+ slots: [service, audio-playback, audio-record]
13 pactl:
14 command: bin/client-wrapper usr/bin/pactl
15- plugs: [client, network]
16- # NOTE: This is deprecated with snapd 2.25 but needs to stay to
17- # guarantee all clients are updated correctly.
18+ plugs: [playback, record, network]
19 paplay:
20 command: bin/client-wrapper usr/bin/paplay
21- plugs: [client, home, network]
22- # NOTE: This is deprecated with snapd 2.25 but needs to stay to
23- # guarantee all clients are updated correctly.
24+ plugs: [playback, home, network]
25 parec:
26 command: bin/client-wrapper usr/bin/parec
27- plugs: [client, home, network]
28- # NOTE: This is deprecated with snapd 2.25 but needs to stay to
29- # guarantee all clients are updated correctly.
30+ plugs: [playback, record, home, network]
31 config:
32 command: bin/config
33
34+# For compatibility reasons, we will still offer the pulseaudio
35+# slot, so older snaps can connect to it.
36 slots:
37 service:
38 interface: pulseaudio
39
40 plugs:
41- client:
42- interface: pulseaudio
43+ playback:
44+ interface: audio-playback
45+ record:
46+ interface: audio-record
47
48 parts:
49 pulseaudio-common:
50@@ -143,7 +141,6 @@ parts:
51 - --disable-systemd-login
52 - --without-caps
53 - --disable-webrtc-aec
54- - --disable-dbus
55 - --disable-oss-output
56 - --disable-oss-wrapper
57 - --disable-jack

Subscribers

People subscribed via source and target branches