Code review comment for ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:fix-route-end-dhcp-lease

The bug you reference says:

FTR, this MP would also help here, although the initially proposed fix for the configuration snap should be enough.

It doesn't sound to me like this is *really* needed? Also the RH bug associated with the first commit isn't viewable w/out a login. ;(-

What version of NM did you cherry pick these fixes from?

Would also mind explaining the actual scenario in some more detail?

It sounds like NM is assuming an existing connection from networkd? And that when this happens, and DHCP leases associated with the connection expire, when a DHCP lease is re-acquired the default route wasn't being restored?

Finally, why is networkd involved here at all? Don't we ship a netplan file which makes NM the default renderer?