Code review comment for ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:not-use-core-support

Revision history for this message
Roberto Mier Escandon (rmescandon) wrote :

I've tested this solution and works perfectly without needing to restart the service.
However it is needed to change the spread tests for not to search for log level in nm daemon start command.

Also, having the log level set in the bin/network-manager explicitly could be misleading, since if you set it to a different value of the one set at the beginning, the startup command in a ps would report other than the current. On the other hand, I'm not sure if it is possible setting the log level somehow at the beginning without having that as startup param...

review: Needs Fixing

« Back to merge proposal