Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:fix-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: f4a05c251884b8199a34048a095138886c600726
Merged at revision: 05f56594a2200e69cd17144a3cb98dd3ea606388
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/network-manager:fix-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager:master
Diff against target: 65 lines (+15/-10)
3 files modified
.gitignore (+4/-0)
snapcraft.yaml (+7/-6)
tests/main/wifi-connect-secured-ap/task.yaml (+4/-4)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Review via email: mp+319062@code.launchpad.net

Commit message

Run NM unit tests

Description of the change

Run NM unit tests

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

@matteo, nice catch, fixed now

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/.gitignore b/.gitignore
index 082484d..3568cd0 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1 +1,5 @@
1/parts/
2/stage/
3/prime/
4network-manager_*.snap
1.tests-extras5.tests-extras
diff --git a/snapcraft.yaml b/snapcraft.yaml
index b809f7b..3498a9b 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -1,5 +1,5 @@
1name: network-manager1name: network-manager
2version: 1.2.2-112version: 1.2.2-11-dev
3summary: Network management framework3summary: Network management framework
4description: |4description: |
5 NetworkManager is a system network service that manages your network5 NetworkManager is a system network service that manages your network
@@ -74,11 +74,7 @@ parts:
7474
75 source: https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager75 source: https://git.launchpad.net/~snappy-hwe-team/snappy-hwe-snaps/+git/network-manager
76 source-type: git76 source-type: git
77 # For development you can directly build from the xenial branch if77 source-branch: network-manager/xenial/1.2.2
78 # needed. Otherwise use the tag to the latest version which will be
79 # used by the published snap.
80 # source-branch: network-manager/xenial/1.2.2
81 source-tag: network-manager-xenial-1.2.2-2
8278
83 build-packages:79 build-packages:
84 - intltool80 - intltool
@@ -162,6 +158,11 @@ parts:
162 - --with-libsoup=no158 - --with-libsoup=no
163 # We want to support ModemManager159 # We want to support ModemManager
164 - --with-modem-manager-1=yes160 - --with-modem-manager-1=yes
161 - --enable-tests=yes
162
163 install: |
164 # Run all tests NetworkManager ships by default
165 make check
165166
166 # Filter files pulled in by stage-packages so they aren't167 # Filter files pulled in by stage-packages so they aren't
167 # included in the final snap. We only need them to build168 # included in the final snap. We only need them to build
diff --git a/tests/main/wifi-connect-secured-ap/task.yaml b/tests/main/wifi-connect-secured-ap/task.yaml
index aa6a70c..4db7449 100644
--- a/tests/main/wifi-connect-secured-ap/task.yaml
+++ b/tests/main/wifi-connect-secured-ap/task.yaml
@@ -19,10 +19,10 @@ execute: |
19 sleep 0.519 sleep 0.5
2020
21 # Setup the AP on wlan021 # Setup the AP on wlan0
22 /snap/bin/wifi-ap.config set wifi.interface wlan022 /snap/bin/wifi-ap.config set wifi.interface=wlan0
23 /snap/bin/wifi-ap.config set wifi.ssid $WIFI_SSID23 /snap/bin/wifi-ap.config set wifi.ssid=$WIFI_SSID
24 /snap/bin/wifi-ap.config set wifi.security wpa224 /snap/bin/wifi-ap.config set wifi.security=wpa2
25 /snap/bin/wifi-ap.config set wifi.security-passphrase $WIFI_PASSPHRASE25 /snap/bin/wifi-ap.config set wifi.security-passphrase=$WIFI_PASSPHRASE
2626
27 # AP needs a bit to appear and be visible for NetworkManager27 # AP needs a bit to appear and be visible for NetworkManager
28 /snap/bin/network-manager.nmcli d wifi rescan28 /snap/bin/network-manager.nmcli d wifi rescan

Subscribers

People subscribed via source and target branches