snappy-hwe-snaps

Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:media-hub-tests into ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master

  1. Git
  2. lp:~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests
  3. media-hub-tests
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 7fd65aec53cbbf387a33b5e29c8f11c8f7f5d8e3
Merged at revision: 4bc86d6f319e7acdacfea969b07d150ebf9a7ff1
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/engineering-tests:media-hub-tests
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/engineering-tests:master
Diff against target: 143 lines (+89/-0)
5 files modified
.gitignore (+4/-0)
README.md (+4/-0)
media-hub/manage.py (+10/-0)
media-hub/units/media-hub.pxu (+65/-0)
snapcraft.yaml (+6/-0)
Reviewer Review Type Date Requested Status
Simon Fels continuous-integration Approve
System Enablement Bot continuous-integration Needs Fixing
Konrad Zapałowicz (community) code Approve
Matteo Croce (community) Approve
Review via email: mp+317454@code.launchpad.net

Commit message

Add manual video playing test cases for media-hub.

This is mostly a draft as things are not properly snapified yet for video playing.

Description of the change

Add manual video playing test cases for media-hub.

This is mostly a draft as things are not properly snapified yet for video playing.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:fa6d1af3754d728271df106d2ef2892f2eab2152
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/945/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/853/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/945/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Matteo Croce (teknoraver) :
review: Approve
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

Ack

review: Approve (code)
Revision history for this message
Simon Fels (morphis) wrote :

LGTM, one minor comment inline.

Thanks for adding the .gitignore file!

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Branch refreshed after addressing comments

Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve
Revision history for this message
Simon Fels (morphis) wrote :

Approving for CI

review: Approve (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :

FAILED: Continuous integration, rev:7fd65aec53cbbf387a33b5e29c8f11c8f7f5d8e3
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/991/
Executed test runs:
    None: https://jenkins.canonical.com/system-enablement/job/generic-update-snap-mp/899/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-enablement/job/generic-build-snap/991/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Approving for CI again.

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/.gitignore b/.gitignore
0new file mode 1006440new file mode 100644
index 0000000..37354e6
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,4 @@
1canonical-se-engineering-tests_*.snap
2parts/
3prime/
4stage/
diff --git a/README.md b/README.md
index 599bbfe..84799b1 100644
--- a/README.md
+++ b/README.md
@@ -27,6 +27,9 @@ running the tests:
2727
28 $ sudo snap install bluez modem-manager network-manager28 $ sudo snap install bluez modem-manager network-manager
2929
30TODO The media-hub framework is not yet snapified. Instructions need to
31be added here when that happens.
32
30Afterwards you have new commands available in /snap/bin you33Afterwards you have new commands available in /snap/bin you
31can use to run all available test cases. The first command34can use to run all available test cases. The first command
32runs all of the tests and the other ones run individual test35runs all of the tests and the other ones run individual test
@@ -38,6 +41,7 @@ categories related to the command's name.
38 $ /snap/bin/canonical-se-engineering-tests.network-manager41 $ /snap/bin/canonical-se-engineering-tests.network-manager
39 $ /snap/bin/canonical-se-engineering-tests.tpm1-242 $ /snap/bin/canonical-se-engineering-tests.tpm1-2
40 $ /snap/bin/canonical-se-engineering-tests.wifi-ap43 $ /snap/bin/canonical-se-engineering-tests.wifi-ap
44 $ /snap/bin/canonical-se-engineering-tests.media-hub
4145
42## How can I contribute new tests?46## How can I contribute new tests?
4347
diff --git a/media-hub/manage.py b/media-hub/manage.py
44new file mode 10075548new file mode 100755
index 0000000..81b22c3
--- /dev/null
+++ b/media-hub/manage.py
@@ -0,0 +1,10 @@
1#!/usr/bin/env python3
2from plainbox.provider_manager import setup, N_
3
4setup(
5 name='plainbox-provider-media-hub',
6 namespace='2017.com.canonical.media-hub',
7 version="1.0",
8 description=N_("Plainbox provider for the media-hub snap"),
9 gettext_domain="2017_com_canonical_media_hub",
10)
diff --git a/media-hub/units/media-hub.pxu b/media-hub/units/media-hub.pxu
0new file mode 10064411new file mode 100644
index 0000000..bdeec69
--- /dev/null
+++ b/media-hub/units/media-hub.pxu
@@ -0,0 +1,65 @@
1# Copyright 2017 Canonical Ltd.
2# All rights reserved.
3#
4# Written by:
5# Alfonso Sánchez-Beato <alfonso.sanchez-beato@canonical.com>
6
7unit: category
8id: media_hub
9_name: media-hub
10
11id: media_hub/video/play_h264
12category_id: media_hub
13plugin: manual
14_summary: H.264 videos play as expected
15_purpose:
16 Check if media-hub plays properly H.264 videos
17_steps:
18 1. Download H.264 video
19 .
20 $ wget https://download.blender.org/durian/trailer/sintel_trailer-720p.mp4
21 .
22 2. Start media-hub-server
23 .
24 $ MIR_SOCKET=/run/user/$UID/mir_socket media-hub-server --desktop_file_hint=unity8
25 .
26 3. Start to play the video
27 .
28 $ MIR_SOCKET=/run/user/$UID/mir_socket QT_QPA_PLATFORM=ubuntumirclient DISPLAY=:0 /usr/bin/mediaplayer-app --desktop_file_hint=unity8 sintel_trailer-720p.mp4
29 .
30 4. Let the video play until the end
31 5. Re-start after the video finishes
32 6. Pause, then press play again a few times
33 7. While the video is playing, move the slider back and forth in time
34 8. Pause the video, then move the slider again
35 9. Re-size, maximize, then minimize the window several times
36_verification:
37 Verify that in all cases the video is played as expected.
38
39id: media_hub/video/play_mpeg4
40category_id: media_hub
41plugin: manual
42_summary: MPEG4 videos play as expected
43_purpose:
44 Check if media-hub plays properly MPEG4 videos
45_steps:
46 1. Download H.264 video
47 .
48 $ wget https://download.blender.org/durian/trailer/Sintel_Trailer.480p.DivX_Home_Theater.divx
49 .
50 2. Start media-hub-server
51 .
52 $ MIR_SOCKET=/run/user/$UID/mir_socket media-hub-server --desktop_file_hint=unity8
53 .
54 3. Start to play the video
55 .
56 $ MIR_SOCKET=/run/user/$UID/mir_socket QT_QPA_PLATFORM=ubuntumirclient DISPLAY=:0 /usr/bin/mediaplayer-app --desktop_file_hint=unity8 Sintel_Trailer.480p.DivX_Home_Theater.divx
57 .
58 4. Let the video play until the end
59 5. Re-start after the video finishes
60 6. Pause, then press play again a few times
61 7. While the video is playing, move the slider back and forth in time
62 8. Pause the video, then move the slider again
63 9. Re-size, maximize, then minimize the window several times
64_verification:
65 Verify that in all cases the video is played as expected.
diff --git a/snapcraft.yaml b/snapcraft.yaml
index 60867c4..622f9cb 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -35,6 +35,8 @@ apps:
35 command: bin/run-udisks2-tests35 command: bin/run-udisks2-tests
36 alsa-utils:36 alsa-utils:
37 command: bin/plainbox-wrapper run -i '2017.com.canonical.alsa-utils::alsa_utils.*'37 command: bin/plainbox-wrapper run -i '2017.com.canonical.alsa-utils::alsa_utils.*'
38 media-hub:
39 command: bin/plainbox-wrapper run -i '2017.com.canonical.media-hub::media_hub.*'
3840
39parts:41parts:
40 common:42 common:
@@ -95,6 +97,10 @@ parts:
95 source-branch: master97 source-branch: master
96 source-subdir: tests/manual98 source-subdir: tests/manual
97 after: [plainbox-local]99 after: [plainbox-local]
100 media-hub:
101 plugin: plainbox-provider
102 source: ./media-hub
103 after: [plainbox-local]
98 launchers:104 launchers:
99 plugin: dump105 plugin: dump
100 source: .106 source: .

Subscribers

People subscribed via source and target branches