Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/build-scripts:fix-beta-version into ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Jim Hodapp
Approved revision: 0a5ece734f7e99fc7b2fc67fca13bce941a4e490
Merged at revision: d46cf8b2bb1d939a3275104455bee59d1df67ba7
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/build-scripts:fix-beta-version
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/build-scripts:master
Diff against target: 66 lines (+14/-6)
2 files modified
jobs/generic-release-snap (+6/-3)
scripts/common.sh (+8/-3)
Reviewer Review Type Date Requested Status
Alfonso Sanchez-Beato continuous-integration Approve
System Enablement Bot continuous-integration Needs Fixing
Jim Hodapp (community) Approve
Review via email: mp+322359@code.launchpad.net

Commit message

The job was creating snaps with version ${NEXT_VERSION}-dev instead of ${VERSION} - fixed that.

Description of the change

The job was creating snaps with version ${NEXT_VERSION}-dev instead of ${VERSION} - fixed that.

To post a comment you must log in.
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/jobs/generic-release-snap b/jobs/generic-release-snap
index b82bf68..29b40b6 100755
--- a/jobs/generic-release-snap
+++ b/jobs/generic-release-snap
@@ -21,7 +21,7 @@ if [ -z "$VERSION" ]; then
21 exit 121 exit 1
22fi22fi
2323
24echo "Snap to be release: $SNAP_NAME"24echo "Snap to be released: $SNAP_NAME"
25echo "Version to be released: $VERSION"25echo "Version to be released: $VERSION"
26echo "New development version: $NEXT_VERSION"26echo "New development version: $NEXT_VERSION"
2727
@@ -63,6 +63,8 @@ bump_version_and_tag $VERSION
63if [ "$RELEASE_FROM_STABLE" -eq 1 ]; then63if [ "$RELEASE_FROM_STABLE" -eq 1 ]; then
64 git push origin $RELEASE_BASE_BRANCH64 git push origin $RELEASE_BASE_BRANCH
65 git push origin $VERSION65 git push origin $VERSION
66
67 $WORKSPACE/build-scripts/scripts/trigger-lp-build.py -s $SNAP_NAME -p
66else68else
67 if ! git branch -r | grep origin/stable ; then69 if ! git branch -r | grep origin/stable ; then
68 git checkout -b stable origin/master70 git checkout -b stable origin/master
@@ -75,11 +77,12 @@ else
75 git push origin $RELEASE_BASE_BRANCH77 git push origin $RELEASE_BASE_BRANCH
76 git push origin $VERSION78 git push origin $VERSION
7779
80 # Build before we change master branch
81 $WORKSPACE/build-scripts/scripts/trigger-lp-build.py -s $SNAP_NAME -p
82
78 git checkout $RELEASE_BASE_BRANCH83 git checkout $RELEASE_BASE_BRANCH
79 sed -i -e "s/^version:\ .*/version: ${NEXT_VERSION}-dev/g" snapcraft.yaml84 sed -i -e "s/^version:\ .*/version: ${NEXT_VERSION}-dev/g" snapcraft.yaml
80 git add snapcraft.yaml85 git add snapcraft.yaml
81 git commit -m "Open development for ${NEXT_VERSION}-dev"86 git commit -m "Open development for ${NEXT_VERSION}-dev"
82 git push origin $RELEASE_BASE_BRANCH87 git push origin $RELEASE_BASE_BRANCH
83fi88fi
84
85exec $WORKSPACE/build-scripts/scripts/trigger-lp-build.py -s $SNAP_NAME -p
diff --git a/scripts/common.sh b/scripts/common.sh
index 0986128..c30d2d7 100755
--- a/scripts/common.sh
+++ b/scripts/common.sh
@@ -67,6 +67,13 @@ set_test_type ()
67 HW_TESTS_RESULT=167 HW_TESTS_RESULT=1
68 fi68 fi
6969
70 # Components have the ability to disable CI tests if they can't provide any.
71 # This is only accepted in a few cases and should be generally avoided.
72 CI_TESTS_DISABLED=no
73 if [ -e "$tmp_srcdir"/src/.ci_tests_disabled ]; then
74 CI_TESTS_DISABLED=yes
75 fi
76
70 rm -rf "$tmp_srcdir"77 rm -rf "$tmp_srcdir"
7178
72 if [ "$FAIL" = yes ]; then79 if [ "$FAIL" = yes ]; then
@@ -74,9 +81,7 @@ set_test_type ()
74 exit 181 exit 1
75 fi82 fi
7683
77 # Components have the ability to disable CI tests if they can't provide any.84 if [ "$CI_TESTS_DISABLED" = yes ]; then
78 # This is only accepted in a few cases and should be generally avoided.
79 if [ -e "$tmp_srcdir"/src/.ci_tests_disabled ]; then
80 echo "WARNING: Component has no CI tests so not running anything here"85 echo "WARNING: Component has no CI tests so not running anything here"
81 exit 086 exit 0
82 fi87 fi

Subscribers

People subscribed via source and target branches