Merge ~alfonsosanchezbeato/snappy-hwe-snaps/+git/alsa-utils:run-on-hw into ~snappy-hwe-team/snappy-hwe-snaps/+git/alsa-utils:master

Proposed by Alfonso Sanchez-Beato
Status: Merged
Approved by: Simon Fels
Approved revision: 4f7f9e9139f19ad3261d7743ff74a2bcce047030
Merged at revision: 0c42fad04f5f5193bf6c7e1c283cca44fdf30fad
Proposed branch: ~alfonsosanchezbeato/snappy-hwe-snaps/+git/alsa-utils:run-on-hw
Merge into: ~snappy-hwe-team/snappy-hwe-snaps/+git/alsa-utils:master
Diff against target: 149 lines (+52/-18)
5 files modified
run-tests.sh (+24/-13)
spread.yaml (+15/-2)
tests/integration/main/content-statefile/task.yaml (+5/-0)
tests/integration/main/documentation-builds/task.yaml (+5/-0)
tests/integration/main/validate-manual-tests/task.yaml (+3/-3)
Reviewer Review Type Date Requested Status
Simon Fels Approve
System Enablement Bot continuous-integration Approve
Jim Hodapp (community) Approve
Konrad Zapałowicz (community) code Approve
Review via email: mp+321824@code.launchpad.net

Commit message

Adapt spread tests so we can run them on real HW

Description of the change

Adapt spread tests so we can run them on real HW

To post a comment you must log in.
Revision history for this message
Konrad Zapałowicz (kzapalowicz) wrote :

ack

review: Approve (code)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) wrote :

Two comments in line, otherwise LGTM

review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Branch refreshed after addressing review comments. See also comments below.

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Simon Fels (morphis) :
review: Needs Fixing
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) :
Revision history for this message
Jim Hodapp (jhodapp) :
Revision history for this message
Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote :

Branch refreshed

Revision history for this message
System Enablement Bot (system-enablement-ci-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

Still looks good to me.

Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/run-tests.sh b/run-tests.sh
index f030283..bb879ba 100755
--- a/run-tests.sh
+++ b/run-tests.sh
@@ -22,20 +22,31 @@ TESTS_EXTRAS_PATH=".tests-extras"
22# Display help.22# Display help.
23# This has to be in sync with the tests-extras/test-runner.sh script23# This has to be in sync with the tests-extras/test-runner.sh script
24# functionalities as the parameters to this one are passed directly there24# functionalities as the parameters to this one are passed directly there
25# this function will quit the script because of the 'exec' keyword
25show_help() {26show_help() {
26 echo "Usage: run-tests.sh [OPTIONS]"27 exec cat <<'EOF'
27 echo28Usage: run-tests.sh [OPTIONS]
28 echo "This is fetch & forget script and what it does is to fetch the"29
29 echo "tests-extras repository and execute the run-tests.sh script from"30This is fetch & forget script and what it does is to fetch the
30 echo "there passing arguments as-is."31tests-extras repository and execute the run-tests.sh script from
31 echo32there passing arguments as-is.
32 echo "optional arguments:"33
33 echo " --help Show this help message and exit"34optional arguments:
34 echo " --channel Select another channel to build the base image from (default: stable)"35 --help Show this help message and exit
35 echo " --snap Extra snap to install"36 --channel=<channel> Select another channel to build the base image from (default: $channel)
36 echo " --debug Enable verbose debugging output"37 --snap=<name> Extra snap to install
37 echo " --test-from-channel Pull network-manager snap from the specified channel instead of building it from source"38 --debug Enable verbose debugging output
38 echo " --force-new-image Force generating a new image used for testing"39 --test-from-channel=<channel> Pull snap from the specified channel instead of building it from source
40 --spread-system=<system> Name of a spread system to use for testing
41 --spread-filter=<filter> Spread filter expressions for test cases
42 --external-address=<IP address> Address of external backend used for testing
43 --external-user=<user name> User name to use on external test backend (default: $external_user)
44 --external-password=<password> Password to use for specified external user (default: $external_password)
45 --force-new-image Force generating a new image used for testing
46 --image-unsigned-core Use an unsigned core snap for the generated image
47 --image-unsigned-gadget Use an unsigned gadget snap for the generated image
48 --image-unsigned-kernel Use an unsigned kernel snap for the generated image
49EOF
39}50}
4051
41# Clone the tests-extras repository52# Clone the tests-extras repository
diff --git a/spread.yaml b/spread.yaml
index c5e1e1b..a4920c2 100644
--- a/spread.yaml
+++ b/spread.yaml
@@ -13,15 +13,17 @@
13# You should have received a copy of the GNU General Public License13# You should have received a copy of the GNU General Public License
14# along with this program. If not, see <http://www.gnu.org/licenses/>.14# along with this program. If not, see <http://www.gnu.org/licenses/>.
1515
16
17project: alsa-utils16project: alsa-utils
1817
18kill-timeout: 2h
19warn-timeout: 40m
20
19environment:21environment:
20 SNAP_NAME: alsa-utils22 SNAP_NAME: alsa-utils
21 PROJECT_PATH: /home/${SNAP_NAME}23 PROJECT_PATH: /home/${SNAP_NAME}
22 TESTSLIB: $PROJECT_PATH/tests/integration/lib24 TESTSLIB: $PROJECT_PATH/tests/integration/lib
23 SNAP_CHANNEL: $(HOST:echo $SNAP_CHANNEL)25 SNAP_CHANNEL: $(HOST:echo $SNAP_CHANNEL)
24 SNAP_ARCH: amd6426 SNAP_ARCH: $(dpkg --print-architecture)
25 SNAP_AUTOCONNECT_CORE_PLUGS: alsa home27 SNAP_AUTOCONNECT_CORE_PLUGS: alsa home
26 SNAP_AUTO_ALIASES: arecord aplay alsamixer amixer alsaucm alsactl speaker-test aseqnet alsatplg arecordmidi amidi alsaloop aconnect iecset alsabat aseqdump aplaymidi28 SNAP_AUTO_ALIASES: arecord aplay alsamixer amixer alsaucm alsactl speaker-test aseqnet alsatplg arecordmidi amidi alsaloop aconnect iecset alsabat aseqdump aplaymidi
2729
@@ -31,6 +33,16 @@ backends:
31 - ubuntu-core-16:33 - ubuntu-core-16:
32 username: test34 username: test
33 password: test35 password: test
36 external:
37 type: adhoc
38 environment:
39 SPREAD_EXTERNAL_ADDRESS: "$(HOST: echo ${SPREAD_EXTERNAL_ADDRESS:-localhost:8022})"
40 allocate: |
41 ADDRESS $SPREAD_EXTERNAL_ADDRESS
42 systems:
43 - hw-ubuntu-core-16:
44 username: $(HOST:echo $SPREAD_EXTERNAL_USER)
45 password: $(HOST:echo $SPREAD_EXTERNAL_PASSWORD)
3446
35path: /home/alsa-utils47path: /home/alsa-utils
3648
@@ -45,6 +57,7 @@ suites:
45 summary: Full-system tests for the alsa-utils snap57 summary: Full-system tests for the alsa-utils snap
46 systems:58 systems:
47 - ubuntu-core-1659 - ubuntu-core-16
60 - hw-ubuntu-core-16
48 prepare: |61 prepare: |
49 . $TESTSLIB/prepare.sh62 . $TESTSLIB/prepare.sh
50 restore-each: |63 restore-each: |
diff --git a/tests/integration/main/content-statefile/task.yaml b/tests/integration/main/content-statefile/task.yaml
index 2782c35..6227ef9 100644
--- a/tests/integration/main/content-statefile/task.yaml
+++ b/tests/integration/main/content-statefile/task.yaml
@@ -1,5 +1,10 @@
1summary: Verify that initial state file can be pulled over the content interface1summary: Verify that initial state file can be pulled over the content interface
22
3systems:
4 # Do not run on real hardware as this test requires an unsigned gadget snap
5 # in the image and we cannot guarantee that in this case.
6 - -hw-ubuntu-core-16
7
3prepare: |8prepare: |
4 . $TESTSLIB/snap-names.sh9 . $TESTSLIB/snap-names.sh
5 snap list | grep $gadget_name | awk '{print $2}' > gadget_version10 snap list | grep $gadget_name | awk '{print $2}' > gadget_version
diff --git a/tests/integration/main/documentation-builds/task.yaml b/tests/integration/main/documentation-builds/task.yaml
index 7fef7b1..ccac8ae 100644
--- a/tests/integration/main/documentation-builds/task.yaml
+++ b/tests/integration/main/documentation-builds/task.yaml
@@ -1,5 +1,10 @@
1summary: Verify the project documentation is building without errors1summary: Verify the project documentation is building without errors
22
3systems:
4 # Do not run on real hardware as documentation-builder is not available in
5 # all archs.
6 - -hw-ubuntu-core-16
7
3execute: |8execute: |
4 # Need to install in devmode as otherwise the snap can't access our project9 # Need to install in devmode as otherwise the snap can't access our project
5 # home which is outside of the home directory of our current user.10 # home which is outside of the home directory of our current user.
diff --git a/tests/integration/main/validate-manual-tests/task.yaml b/tests/integration/main/validate-manual-tests/task.yaml
index 1b8b481..8edd337 100644
--- a/tests/integration/main/validate-manual-tests/task.yaml
+++ b/tests/integration/main/validate-manual-tests/task.yaml
@@ -2,7 +2,7 @@ summary: Validate all manual plainbox test cases so that we don't ship any broke
22
3execute: |3execute: |
4 snap install --devmode --beta classic4 snap install --devmode --beta classic
5 cat <<-EOF > /home/test/validate-manual-tests.sh5 cat <<-EOF > ${PROJECT_PATH}/validate-manual-tests.sh
6 #!/bin/sh6 #!/bin/sh
7 set -ex7 set -ex
8 apt update8 apt update
@@ -13,5 +13,5 @@ execute: |
13 python3 manage.py develop13 python3 manage.py develop
14 python3 manage.py validate14 python3 manage.py validate
15 EOF15 EOF
16 chmod +x /home/test/validate-manual-tests.sh16 chmod +x ${PROJECT_PATH}/validate-manual-tests.sh
17 sudo classic /home/test/validate-manual-tests.sh17 sudo classic ${PROJECT_PATH}/validate-manual-tests.sh

Subscribers

People subscribed via source and target branches