review-tools

Merge ~alfonsosanchezbeato/review-tools:add-core24-polkit into review-tools:master

  1. Git
  2. lp:~alfonsosanchezbeato/review-tools
  3. add-core24-polkit
  4. Merge into master
Proposed by Alfonso Sanchez-Beato
Status: Merged
Merged at revision: f70d5f47b86ebfa9e8329e85036d60a22ff34240
Proposed branch: ~alfonsosanchezbeato/review-tools:add-core24-polkit
Merge into: review-tools:master
Diff against target: 12 lines (+1/-0)
1 file modified
reviewtools/overrides.py (+1/-0)
Reviewer Review Type Date Requested Status
Paulo Flabiano Smorigo Approve
Nishit Majithia Approve
Review via email: mp+458243@code.launchpad.net

Commit message

overrides.py: add exception for polkit agent in core24

Needed as polkit is now included in the core24 base.

Description of the change

overrides.py: add exception for polkit agent in core24

Needed as polkit is now included in the core24 base.

To post a comment you must log in.
Revision history for this message
Nishit Majithia (0xnishit) wrote :

this exception in review tools is needed as the permission of /usr/lib/polkit-1/polkit-agent-helper-1 is as expected, this looks good to me

review: Approve
Revision history for this message
Paulo Flabiano Smorigo (pfsmorigo) wrote :

As Nishit said, this override is expected. LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
2index 5be214a..29a533b 100644
3--- a/reviewtools/overrides.py
4+++ b/reviewtools/overrides.py
5@@ -386,6 +386,7 @@ sec_mode_overrides = {
6 "./usr/bin/wall": "rwxr-sr-x",
7 "./usr/lib/dbus-1.0/dbus-daemon-launch-helper": "rwsr-xr--",
8 "./usr/lib/openssh/ssh-keysign": "rwsr-xr-x",
9+ "./usr/lib/polkit-1/polkit-agent-helper-1": "rwsr-xr-x",
10 "./usr/sbin/pam_extrausers_chkpwd": "rwxr-sr-x",
11 "./usr/sbin/unix_chkpwd": "rwxr-sr-x",
12 "./var/mail": "rwxrwsr-x",

Subscribers

People subscribed via source and target branches