Code review comment for ~alfonsosanchezbeato/network-manager:call-netplan-apply

Revision history for this message
Ian Johnson (anonymouse67) wrote :

@Tony can you add denials from system journal as well?

The snapd policy explicitly supports using the D-Bus API, we have tests in snapd for this. See: https://github.com/snapcore/snapd/tree/master/tests/main/fake-netplan-apply and https://github.com/snapcore/snapd/blob/master/tests/main/ubuntu-core-netplan/task.yaml

Also @Alfonso, upstream netplan has this for the dbus call:

https://github.com/CanonicalLtd/netplan/blob/master/netplan/cli/commands/apply.py#L55-L60

Which uses busctl instead of dbus-send, so perhaps there's some difference between dbus-send and busctl? I remember running into issues with dbus-send defaulting to the session bus and busctl defaulting to the system bus or something like that, but you're explicitly setting the system bus so I'm not sure what the issue is.

« Back to merge proposal