Code review comment for ~alfonsosanchezbeato/network-manager:test-ci

Revision history for this message
Tony Espy (awe) wrote :

> @Tony, correct, that is what I was referring to. I have changed the commit
> message to reflect that, and also added an explanation on why I included the
> resolvconf files:
>
> <<
> snap: add pppd and resolvconf scripts to the snap
>
> These files cannot be accessed from the snap anymore as they are not
> included in the core18 base. Note that the resolvconf scripts will be
> used only when installed in a UC16 system.
>
> The resolvconf files had to be modified to use the right folders, that
> is the reason for including them instead of staging from the debian
> package.
> >>

Sure, but you couldn't you do this by applying patches to the files pulled out of the stage-package? Using your approach we're flying blind wrt to resolvconf CVEs.

« Back to merge proposal