Code review comment for lp:~alexwolf/stellarium/equation-of-time

Revision history for this message
gzotti (georg-zotti) wrote :

Hi!

No change, I am afraid :-(

But during the crash, my config.ini is corrupted! It is left as empty
file. If I delete it, a new file is created, again empty.

BTW, plugins/EquationOfTime/src/EquationOfTime.cpp, near line 674, you may
use fmod(sunMeanLongitude, 360.0) for a faster modulo, then add 360 if <0.
But this is not causing the problems. Does it work for you on Windows?

Kind regards,
Georg

On Do, 6.02.2014, 18:05, Alexander Wolf wrote:
> Dear Georg,
>
> can you check plugin after refactoring?
> --
> https://code.launchpad.net/~alexwolf/stellarium/equation-of-time/+merge/205011
> Your team Stellarium is requested to review the proposed merge of
> lp:~alexwolf/stellarium/equation-of-time into lp:stellarium.
>

« Back to merge proposal