Code review comment for lp:~alexwolf/stellarium/equation-of-time

Hi Alex!

it crashes just after boot. :-( (Win7, i7/NVidia)

end of logfile:

=============
Loading constellation boundary data ...
Loaded 782 constellation boundary segments
StelPainter: initGLShaders()...
StelPainter: initGLShaders()... done
Creating GUI ...
ASSERT: "matAltAzModelView[0]==matAltAzModelView[0]" in file
C:\Stellarium_DEV\BZR\equation-of-time\src\core\StelCore.cpp, line 665
QWidget::repaint: Recursive repaint detected
QPainter::begin: A paint device can only be painted by one painter at a time.
QPainter::setRenderHint: Painter must be active to set rendering hints
QPainter::setRenderHint: Painter must be active to set rendering hints
QPainter::worldTransform: Painter not active
QPainter::setWorldTransform: Painter not active
QPainter::setOpacity: Painter not active
QPainter::setWorldTransform: Painter not active
QPainter::setOpacity: Painter not active
QPainter::beginNativePainting: Painter not active
ASSERT: "matAltAzModelView[0]==matAltAzModelView[0]" in file
C:\Stellarium_DEV\BZR\equation-of-time\src\core\StelCore.cpp, line 665
=============

Not sure if the assert was guilty or the recursive repaint. The latter has
caused some occasional crashes for me in the past (will that be solved by
the changes for QML2?), but this is consistently failing now.

Kind regards,
Georg

On Mi, 5.02.2014, 18:23, Alexander Wolf wrote:
> Alexander Wolf has proposed merging
> lp:~alexwolf/stellarium/equation-of-time into lp:stellarium.
>
> Requested reviews:
> Stellarium (stellarium)
>
> For more details, see:
> https://code.launchpad.net/~alexwolf/stellarium/equation-of-time/+merge/205011
>
> I propose for merging the plugin, which shows the solution of the equation
> of time on top of the screen. In future this plugin can be extend for
> generate the graph for equation of time for year.
> --
> https://code.launchpad.net/~alexwolf/stellarium/equation-of-time/+merge/205011
> Your team Stellarium is requested to review the proposed merge of
> lp:~alexwolf/stellarium/equation-of-time into lp:stellarium.
>