Merge ~alextu/plainbox-provider-pc-sanity:move-turbostate-to-ppc-rc2 into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: 6b47282eb91796cf757eb7ef7c970accd72c9ddb
Proposed branch: ~alextu/plainbox-provider-pc-sanity:move-turbostate-to-ppc-rc2
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 114 lines (+6/-84)
2 files modified
dev/null (+0/-73)
units/pc-sanity/pc-sanity.pxu (+6/-11)
Reviewer Review Type Date Requested Status
Yuan-Chen Cheng (community) Approve
Kai-Chuan Hsieh Approve
Review via email: mp+399205@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Kai-Chuan Hsieh (kchsieh) wrote :

LGTM.

review: Approve
Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Alex Tu (alextu) wrote :
Revision history for this message
Yuan-Chen Cheng (ycheng-twn) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/pc-sanity/pc-sanity-power-consumption.pxu b/units/pc-sanity/pc-sanity-power-consumption.pxu
2deleted file mode 100644
3index f6d7716..0000000
4--- a/units/pc-sanity/pc-sanity-power-consumption.pxu
5+++ /dev/null
6@@ -1,73 +0,0 @@
7-
8-
9-plugin: shell
10-category_id: com.canonical.plainbox::miscellanea
11-id: miscellanea/turbostate-s2i-power-residency
12-after: miscellanea/turbostate-long-idle-c10
13-depends: power-management/cpu-low-power-idle
14-user: root
15-command:
16- set -x
17- check-turbostat-power-residency.sh --s2i
18-_summary: check if expected power residency on s2i
19-_description:
20- check if target machine can get expected power residency on e.g. cpu pkg c10, s0ix, gfxrc6..etc
21- this test case refer to Intel document : https://01.org/blogs/qwang59/2020/linux-s0ix-troubleshooting
22-
23-plugin: shell
24-category_id: com.canonical.plainbox::miscellanea
25-id: miscellanea/turbostate-short-idle-c10
26-depends: power-management/cpu-low-power-idle
27-command:
28- set -x
29- report_folder="$HOME/submission-report-$(date +%Y%m%d%H%M)"
30- mkdir -p "$report_folder"
31- dpkg -s linux-tools-"$(uname -r)" || sudo apt-get install -y linux-tools-"$(uname -r)"
32- for i in $(sudo turbostat --list | sed 's/,/ /g'); do
33- if [ -z "${i##*pc*}" ]; then
34- echo $i
35- if [ -z "$COL" ]; then
36- COL="$i";
37- else
38- COL="$COL,$i";
39- fi
40- fi;
41- done;
42- sudo turbostat --num_iterations 20 --show "$COL" 2>&1 | tee "$report_folder"/turbostat-pkgpc-shortidle.log
43- tail -n1 "$report_folder"/turbostat-pkgpc.log | grep "0.00$" && false
44-_summary: check if target machine can get cpu pkg c10 in short idle.
45-_description:
46- check if target machine can get cpu pkg c10 in short idle. detail history: https://trello.com/c/3C0b5Nkt
47-
48-plugin: shell
49-category_id: com.canonical.plainbox::miscellanea
50-id: miscellanea/turbostate-long-idle-c10
51-depends: power-management/cpu-low-power-idle
52-command:
53- set -x
54- report_folder="$HOME/submission-report-$(date +%Y%m%d%H%M)"
55- mkdir -p "$report_folder"
56- dpkg -s linux-tools-"$(uname -r)" || sudo apt-get install -y linux-tools-"$(uname -r)" || exit 1
57- dpkg -s xautomation || sudo apt-get install -y xautomation || exit 1
58- gsettings set org.gnome.desktop.session idle-delay 10
59- sleep 30
60- for i in $(sudo turbostat --list | sed 's/,/ /g'); do
61- if [ -z "${i##*pc*}" ]; then
62- echo $i
63- if [ -z "$COL" ]; then
64- COL="$i";
65- else
66- COL="$COL,$i";
67- fi
68- fi;
69- done;
70- sudo turbostat --num_iterations 30 --show "$COL" 2>&1 | tee "$report_folder"/turbostat-pkgpc-longidle.log
71- DISPLAY=:0 xte 'key Up'
72- gsettings set org.gnome.desktop.session idle-delay 0
73- # cat additional message for reference
74- sudo cat /sys/kernel/debug/pmc_core/package_cstate_show
75- # set false in the end when it failed so that test case be marked as failed.
76- ! (tail -n1 "$report_folder"/turbostat-pkgpc-longidle.log | grep "0.00$")
77-_summary: check if target machine can get cpu pkg c10 in long idle.
78-_description:
79- check if target machine can get cpu pkg c10 in long idle. detail history: https://trello.com/c/3C0b5Nkt
80diff --git a/units/pc-sanity/pc-sanity.pxu b/units/pc-sanity/pc-sanity.pxu
81index 2bc3739..91acf47 100644
82--- a/units/pc-sanity/pc-sanity.pxu
83+++ b/units/pc-sanity/pc-sanity.pxu
84@@ -13,8 +13,12 @@ include:
85 com.canonical.certification::miscellanea/cvescan
86 com.canonical.certification::miscellanea/check-nvidia
87 com.canonical.certification::miscellanea/debsums
88- com.canonical.certification::miscellanea/turbostate-long-idle-c10
89- com.canonical.certification::miscellanea/turbostate-s2i-power-residency
90+ com.canonical.certification::power-management/check-turbostat-long-idle-cpu-residency
91+ com.canonical.certification::power-management/check-turbostat-long-idle-s0ix-residency
92+ com.canonical.certification::power-management/check-turbostat-long-idle-gfxrc6-residency
93+ com.canonical.certification::power-management/check-turbostat-s2i-cpu-residency
94+ com.canonical.certification::power-management/check-turbostat-s2i-s0ix-residency
95+ com.canonical.certification::power-management/check-turbostat-s2i-gfxrc6-residency
96 com.canonical.certification::miscellanea/intel-rapl
97 com.canonical.certification::miscellanea/intel-rapl-mmio
98 com.canonical.certification::miscellanea/intel-p-state
99@@ -37,15 +41,6 @@ bootstrap_include:
100 device
101 graphics_card
102
103-id: sleep-state-auto
104-_name: sleep-state-auto (Ubuntu Desktop)
105-unit: test plan
106-_description:
107- This test plan collected all auto test related to sleep state.
108-include:
109- com.canonical.certification::miscellanea/turbostate-long-idle-c10
110- com.canonical.certification::miscellanea/turbostate-s2i-power-residency
111-
112 id: graphics-dgpu-auto-switch-testing
113 unit: test plan
114 _name: A test plan to confirm dgpu auto switch works well.

Subscribers

People subscribed via source and target branches