Merge ~alextu/plainbox-provider-pc-sanity:gate_rste_raid into plainbox-provider-pc-sanity:master

Proposed by Alex Tu
Status: Merged
Merged at revision: b956f93e2a53a1042219f1403631fcdd0aac2c3d
Proposed branch: ~alextu/plainbox-provider-pc-sanity:gate_rste_raid
Merge into: plainbox-provider-pc-sanity:master
Diff against target: 41 lines (+27/-0)
2 files modified
debian/changelog (+6/-0)
usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu (+21/-0)
Reviewer Review Type Date Requested Status
Shih-Yuan Lee Approve
Rex Tsai Pending
OEM Solutions Group: Engineers Pending
Review via email: mp+382731@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

Please follow https://launchpadlibrarian.net/468773053/hw-detect_1.117ubuntu8.debdiff to check the value of /sys/module/ahci/drivers/pci\:ahci/*/remapped_nvme.

review: Needs Fixing
Revision history for this message
Shih-Yuan Lee (fourdollars) :
review: Needs Fixing
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/debian/changelog b/debian/changelog
index 91a3d8c..e77a5c2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
1plainbox-provider-pc-sanity (0.2.6ubuntu2) UNRELEASED; urgency=medium
2
3 * add gate_rste_raid case
4
5 -- Alex Tu <alex.tu@canonical.com> Wed, 22 Apr 2020 15:49:10 +0800
6
1plainbox-provider-pc-sanity (0.2.6ubuntu1) bionic; urgency=medium7plainbox-provider-pc-sanity (0.2.6ubuntu1) bionic; urgency=medium
28
3 * bump version9 * bump version
diff --git a/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu
4new file mode 10064410new file mode 100644
index 0000000..5ef6585
--- /dev/null
+++ b/usr/share/plainbox-provider-checkbox/units/pc-sanity/pc-sanity-check-env.pxu
@@ -0,0 +1,21 @@
1plugin: shell
2category_id: com.canonical.plainbox::miscellanea
3id: miscellanea/gate_rste_raid
4command:
5 set -x
6 # copy from script https://launchpadlibrarian.net/468773053/hw-detect_1.117ubuntu8.debdiff
7 for ahci_device in /sys/module/ahci/drivers/pci\:ahci/*/remapped_nvme
8 do
9 if [ -f "$ahci_device" ]; then
10 ref_count="$(cat "$ahci_device")"
11 if [ "$ref_count" -ge 1 ]; then
12 echo "Intel RAID/RST mode detected."
13 exit 1
14 else
15 echo "No Intel RAID/RST mode detected."
16 fi
17 fi
18 done
19_summary: to confirm the dell-recoery is what we expected.
20_description:
21 we don't support RSTe raid, so gate it based on https://docs.google.com/document/d/13G8VkaFB8W2ck-vtzu4OqkYFmi7-w0ooi6qNpxJLtPY/edit#

Subscribers

People subscribed via source and target branches