Merge ~alexmurray/ubuntu-security-tools:uaudit-rubocop into ubuntu-security-tools:master

[Alex Murray]

[Mark Esler (eslerm)]

This looks great Alex! Thank you.

rubocop is a fairly verbose code linter, so I recommend adding `--only Security`.

review: Approve

[Alex Murray (alexmurray)]

Thanks Mark - I think I might also add --enable-pending-cops too in this case to try and get as much coverage as possible from the security linters.

diff --git a/audits/jira.template b/audits/jira.template
index 0a94a9a..82c83ff 100644
--- a/audits/jira.template
+++ b/audits/jira.template
@@ -9,6 +9,7 @@ $scc
 - $coverity coverity defects
 - $bandit warnings from bandit
 - $brakeman brakeman defects
+- $rubocop rubocop defects
 - $flawfinder flawfinder defects
 - $cppcheck warnings from cppcheck
 - $shellcheck warnings from shellcheck
diff --git a/audits/uaudit b/audits/uaudit
index af32fd5..3d0300b 100755
--- a/audits/uaudit
+++ b/audits/uaudit
@@ -165,6 +165,15 @@ static_analysis_tools = [
         cmd_end=["."],
         summary=["sed", "/^Processed/q", OUTPUT_FILE],
     ),
+    StaticAnalysisTool(
+        "rubocop",
+        source=StaticAnalysisToolSource.DEB,
+        cmd_start=["rubocop", "--no-color", "--enable-pending-cops", "--only", "Security"],
+        cmd_json=["--format", "json"],
+        cmd_txt=["--format", "emacs"],
+        cmd_end=["."],
+        summary=["grep", "-c", "^\\./", OUTPUT_FILE]
+    ),
 ]