Code review comment for ~alexmurray/ubuntu-cve-tracker:restore-release-stamps-and-sort-instead-by-release-version

Revision history for this message
Emilia Torino (emitorino) wrote :

Thanks for considering this!

I have a question before moving fw, should trusty/esm (which its stamp is 04/2019) be consider before or after xenial (04/2016)?

With this code, trusty/esm is ordered before xenial:

>>> r = ["jammy", "focal", "trusty/esm", "esm-apps/bionic", "trusty", "xenial", "bionic", "esm-apps/jammy"]
>>> import cve_lib
>>> cve_lib.release_sort(r)
['trusty', 'trusty/esm', 'xenial', 'bionic', 'esm-apps/bionic', 'focal', 'jammy', 'esm-apps/jammy']

Maybe this is ok for the uses cases under consideration.

« Back to merge proposal