Code review comment for ~alexmurray/ubuntu-cve-tracker:package-db-json-validation

Revision history for this message
Alex Murray (alexmurray) wrote :

Thanks for the feedback Steve - I agree, the one-big-json is a lot more user-unfriendly than I expected - so I have now reverted that change and instead have reinstated the boilerplate files *but* with the crucial difference that we now parse them to create the package-db structure. As such your comments about accessor methods etc are all still valid and this would definitely be worth investigating but in a separate MR, since this one is no longer valid.

Let's discuss more in Prague if not beforehand.

review: Disapprove

« Back to merge proposal