review-tools

~alexmurray/review-tools:lp-2021942

  1. Git
  2. lp:~alexmurray/review-tools
  3. lp-2021942
Last commit made on 2023-05-31
Get this branch:
git clone -b lp-2021942 https://git.launchpad.net/~alexmurray/review-tools
Only Alex Murray can upload to this branch. If you are Alex Murray please log in for upload directions.

Branch merges

Branch information

Name:
lp-2021942
Repository:
lp:~alexmurray/review-tools

Recent commits

2b12ae5... by Alex Murray

snapcraft.yaml: set PYTHONPATH explicitly for staged packages

To fix LP: #2021942

Signed-off-by: Alex Murray <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
1 → 2 of 2 results First • Previous • Next • Last
03a2509... by Alex Murray

update changelog for release

Signed-off-by: Alex Murray <email address hidden>

678d2bc... by Alex Murray

sr_lint.py: accept tilde (~) as a valid URL character

Fixes LP: #2020903

Signed-off-by: Alex Murray <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
1 → 2 of 2 results First • Previous • Next • Last
a1d79cd... by Alex Murray

Merge remote-tracking branch 'shanepelletier/ensure-snaps-using-devel-base-are-devel'

Signed-off-by: Alex Murray <email address hidden>

eeff05b... by Paulo Flabiano Smorigo

update changelog for release

Signed-off-by: Paulo Flabiano Smorigo <email address hidden>

f00f8f2... by Paulo Flabiano Smorigo

Merge branch 'pfsmorigo/move_to_newer_core'

24ac337... by Shane M. Pelletier

Ensure that snaps using `devel` bases are `devel`

It is currently possible for snaps to be declared as `grade: stable`
even though they declare a base that is `grade: devel`. This change
requires snaps with a `grade: devel` base to also be `grade: devel`.

For extra clarifty, the allowed combinations are:
* A `grade: devel` snap with a `grade: devel` base.
* A `grade: devel` snap with a `grade: stable` base.
* A `grade: stable` snap with a `grade: stable` base.

The list of base snaps declared as `grade: stable` was found using
the SQL query located at [1].

[1] https://git.launchpad.net/snap-reports/tree/stable-base-snaps.sql

5e5dd3b... by Alex Murray

sr_lint.py: appease flake8 regex checks

Signed-off-by: Alex Murray <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
1 → 2 of 2 results First • Previous • Next • Last
4b31457... by Alex Murray

sr_lint.py: validate listen-stream with daemon-scope: user correctly

When a snap daemon has daemon-scope: user, listen-stream should then only be
valid for SNAP_USER_DATA / SNAP_USER_COMMON or XDG_RUNTIME_DIR

See
https://github.com/snapcore/snapd/blob/ce63d447618575340462191152fe36614a0d189e/snap/validate.go#L217-L238

Signed-off-by: Alex Murray <email address hidden>

Failed
[FAILED] test:0 (build)
[WAITING] coverage:0 (build)
1 → 2 of 2 results First • Previous • Next • Last
3a8c4fe... by Alex Murray

sr_lint.py: accept $XDG_RUNTIME_DIR as a valid listen-stream prefix

see https://dashboard.snapcraft.io/snaps/ubuntu-desktop-session/revisions/11/
and
https://github.com/snapcore/snapd/blob/ce63d447618575340462191152fe36614a0d189e/wrappers/services.go#L1492-L1515
and
https://github.com/snapcore/snapd/blob/ce63d447618575340462191152fe36614a0d189e/snap/validate.go#L217-L238
for context

Signed-off-by: Alex Murray <email address hidden>

Succeeded
[SUCCEEDED] test:0 (build)
[SUCCEEDED] coverage:0 (build)
1 → 2 of 2 results First • Previous • Next • Last