Code review comment for lp:~alexander-wilms/midori/midori

Revision history for this message
Danielle Foré (danrabbit) wrote :

I agree the title needs to state the entire problem concisely. I think something like "Foobar can't be found" would work well.

While I don't really think the logo is required, if Christian wants it in it needs to stay.

I do think that having the white "dialog" on a grey page looks a little nicer here (even though it's not 100% consistent with how granite does embedded error pages, it is more consistent with how other people do embedded error pages). I would suggest a small border radius (like 4px) and a very small, light shadow.

I'm not sure the line "You might want to try one of these suggestions:" is entirely necessary. I think you could jump straight from the description to the bulleted list.

review: Needs Fixing

« Back to merge proposal