Code review comment for lp:~alecu/unity-scope-click/verify-sha512

Revision history for this message
Alejandro J. Cura (alecu) wrote :

> Code looks good but yeah, I second Rodney's question: what happens when hash
> is invalid? Will we report a download failure?

There's no way to distinguish a wrong hash, from a good hash but the wrong download (ie, because some cache is serving the wrong content, or with some flipped bits).
That's a failure in the download and in many cases it's a retryable error, so I think the current error shown by the scope is ok, but I agree that the wording could be improved.

« Back to merge proposal