Code review comment for lp:~alecu/unity-scope-click/uninstallable-scopes

Revision history for this message
dobey (dobey) wrote :

I still have a concern about the version not being used in the operator== for Package, as in its current state it can result in the store showing "INSTALLED" for a newer version of the package than is installed, which, when the new preview design is implemented, can result in the change log showing disparate information in the preview, resulting in the app running without any new changes, when the update has not been installed. However, this is a new issue, primarily with a design that is not yet implemented, so I don't think we should block this branch on that.

Also, the po/POTFILES.in will need updated, but I will do that in a separate branch.

review: Approve

« Back to merge proposal