Code review comment for lp:~alecu/unity-scope-click/uninstallable-scopes

Revision history for this message
dobey (dobey) wrote :

/home/phablet/uninstallable-scopes/libclickscope/click/interface.cpp:406:56: error: converting to ‘std::unordered_set<click::Package>’ from initializer list would use explicit constructor ‘std::unordered_set<_Value, _Hash, _Pred, _Alloc>::unordered_set(std::unordered_set<_Value, _Hash, _Pred, _Alloc>::size_type, const hasher&, const key_equal&, const allocator_type&) [with _Value = click::Package; _Hash = std::hash<click::Package>; _Pred = std::equal_to<click::Package>; _Alloc = std::allocator<click::Package>; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::size_type = unsigned int; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::hasher = std::hash<click::Package>; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::key_equal = std::equal_to<click::Package>; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::allocator_type = std::allocator<click::Package>]’
                 callback({}, InterfaceError::ParseError);
                                                        ^
/home/phablet/uninstallable-scopes/libclickscope/click/interface.cpp:410:51: error: converting to ‘std::unordered_set<click::Package>’ from initializer list would use explicit constructor ‘std::unordered_set<_Value, _Hash, _Pred, _Alloc>::unordered_set(std::unordered_set<_Value, _Hash, _Pred, _Alloc>::size_type, const hasher&, const key_equal&, const allocator_type&) [with _Value = click::Package; _Hash = std::hash<click::Package>; _Pred = std::equal_to<click::Package>; _Alloc = std::allocator<click::Package>; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::size_type = unsigned int; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::hasher = std::hash<click::Package>; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::key_equal = std::equal_to<click::Package>; std::unordered_set<_Value, _Hash, _Pred, _Alloc>::allocator_type = std::allocator<click::Package>]’
             callback({}, InterfaceError::CallError);
                                                   ^
libclickscope/click/CMakeFiles/clickscope.dir/build.make:126: recipe for target 'libclickscope/click/CMakeFiles/clickscope.dir/interface.cpp.o' failed

These compilation errors with gcc 4.9 seem to be a result of the changes in this branch. Can we have some plan to fix them before we get upgraded to 4.9 again, even though this compiles ok under 4.8?

review: Needs Information

« Back to merge proposal