Code review comment for lp:~alecu/unity-scope-click/missing-preview-fields

Revision history for this message
dobey (dobey) wrote :

I'm a bit worried about the lack of translation in the size formatting code. For example, here is the glib code for formatting sizes: https://git.gnome.org/browse/glib/tree/glib/gutils.c#n2103

It looks like we're expecting boost to do some magic here, and just tack a 'b' or 'bytes' on the end (and 'b' is wrong there, since 'B' is the correct symbol for bytes, at least in US).

review: Needs Information

« Back to merge proposal