Merge lp:~alecu/unity-scope-click/fix-static-translations into lp:unity-scope-click/devel
Proposed by
Alejandro J. Cura
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Paweł Stołowski | ||||
Approved revision: | 411 | ||||
Merged at revision: | 413 | ||||
Proposed branch: | lp:~alecu/unity-scope-click/fix-static-translations | ||||
Merge into: | lp:unity-scope-click/devel | ||||
Diff against target: |
75 lines (+6/-13) 3 files modified
libclickscope/click/preview.cpp (+3/-7) libclickscope/click/preview.h (+0/-3) libclickscope/tests/test_preview.cpp (+3/-3) |
||||
To merge this branch: | bzr merge lp:~alecu/unity-scope-click/fix-static-translations | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Diego Sarmentero (community) | Approve | ||
Paweł Stołowski (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Approve | |
Review via email: mp+231461@code.launchpad.net |
Commit message
Do not use static const strings for translations.
To post a comment you must log in.
PASSED: Continuous integration, rev:411 jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- ci/277/ jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- amd64-ci/ 252 jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- armhf-ci/ 251 jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- armhf-ci/ 251/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ unity-team- unity-scope- click-devel- utopic- i386-ci/ 251
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity- team-unity- scope-click- devel-ci/ 277/rebuild
http://