Code review comment for lp:~alecu/unity-scope-click/download-errors

> + preview.add_action (new Unity.PreviewAction (ACTION_DOWNLOAD_FAILED, ("***
> download_failed"), null));
>
> What the heck? Why are we adding weird buttons like this to the UI?
>
> This is exactly what bug #1231145 is filed about. We should remove such
> things, not add more of them.

PreviewActions are not always buttons.

In the case of this preview, when the the dash finds out that it needs to show a progressbar, it does not show any button, and uses those two special actions (the ones that start with ***) to signal that the download manager has finished or errored out.

It was a bug that the action labeled with "*** ..." was shown as a button, but having the stars there helped uncover it.