Code review comment for lp:~alecu/ubuntuone-client/proxy-tunnel-server

Manuel de la Peña (mandel) wrote :

I dont think that the following code is correct:

787 + else:
788 + return QNetworkProxy(QNetworkProxy.HttpProxy,
789 + hostName=settings.get("host", ""),
790 + port=settings.get("port", 0),
791 + user=settings.get("username", ""),
792 + password=settings.get("password", ""))

The use of "" for the username and password will give problems when dealing with the auth proxies because the first attempt would be to use them and therefore you will get a 401 instead of a 407.

505 +
506 + def test_stop_but_never_connected(self):
507 + """Stop but it was never connected."""
508 + fake_protocol = FakeServerTunnelProtocol()
509 + client = tunnel_server.RemoteSocket(fake_protocol)
510 + yield client.stop()

There is a missing decorator in the test.

review: Needs Fixing

« Back to merge proposal