> * As far as I see, there is no need to have an __init__ method for
> FakeIPCRoot.
The empty method on FakeIPCRoot is needed in order to override the default constructor. I've added a comment to clarify this.
> > * I think this code needs to be deleted since is not used:
>
> def on_credentials_found_cb(self, app_name, creds, *args, **kwargs):
>
> def on_credentials_error_cb(self, app_name, *args, **kwargs):
Hi, thanks for the review!
> * As far as I see, there is no need to have an __init__ method for
> FakeIPCRoot.
The empty method on FakeIPCRoot is needed in order to override the default constructor. I've added a comment to clarify this.
> > * I think this code needs to be deleted since is not used: found_cb( self, app_name, creds, *args, **kwargs): error_cb( self, app_name, *args, **kwargs):
>
> def on_credentials_
>
> def on_credentials_
This is now fixed and pushed.
> * The rest looks great!
thanks!