Code review comment for lp:~alecu/ubuntuone-client/fix-cmt-usage

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

* As far as I see, there is no need to have an __init__ method for FakeIPCRoot.

* I think this code needs to be deleted since is not used:

    def on_credentials_found_cb(self, app_name, creds, *args, **kwargs):

    def on_credentials_error_cb(self, app_name, *args, **kwargs):

* The rest looks great!

review: Needs Fixing

« Back to merge proposal