Code review comment for lp:~alecu/ubuntuone-client/cleanup-emit-signals

Revision history for this message
Manuel de la Peña (mandel) wrote :

A small comment, sending the entire collection of remote_calls to be signals seems wrong to me. Because remove_calls can be all the calls that can be remotly called from the client. I know that at this point we just have signals.. but who knows, what about using the @signal decorator to create a signals collection? Or at least a subset of all the remote_calls.

review: Needs Fixing

« Back to merge proposal