Ubuntu Single Sign On Client

Code review comment for lp:~alecu/ubuntu-sso-client/restful-client

  1. restful-client
  2. Merge into trunk
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Could you please put the value of reply.readAll() in a variable and use that in the 3 lines that uses it?

Shall you also assert on RestfulClient.__init__ that the iri is unicode?

Rest looks good! I will mark as approved but please change the readAll() thingy.

review: Approve

« Back to merge proposal