Awn

Code review comment for lp:~albyrock87/awn/awn-lucido

Revision history for this message
Michal Hruby (mhr3) wrote :

I'm not going to do a detailed code review of the drawing code (as I didn't write most of that code anyway), the rest looks quite good, though there are a few issues:
Changes to Edgy you introduced bring a bug on the circle when you're using semi-transparent colors. Also if the code is about to be kept, get rid of the craziness with memcpy of GdkRectangle - it's a simple struct, allocating it on stack and assigning to it will work just fine.
Also it'd be nice to add public getter/setter methods for the new properties in AwnSeparator.

review: Needs Fixing (code-review)

« Back to merge proposal