Code review comment for lp:~albertomilone/unity-settings-daemon/lp1287341-14.10

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work

Some review nitpicks:

> static int map_touch_to_output(GnomeRRScreen *screen, int device_id, GnomeRROutputInfo *output);

lacks a space before the function name and the parenthesis

> static void do_touchscreen_mapping(GsdXrandrManager *manager);

same

> do_touchscreen_mapping(manager);

same

> log_msg("\nSetting touchscreen mapping on RandR event\n");

same

> if (manager->priv->main_touchscreen_name)
> g_free(manager->priv->main_touchscreen_name);

no need to check if the value is null, g_free does that for you

Looks fine to looks otherwise, can you just clean those out? Then I'm going to handle the landing

review: Needs Fixing

« Back to merge proposal