Code review comment for lp:~albertog/siesta/merge-OSSO
Revision history for this message
| Nick Papior (nickpapior) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Very good Alberto.
I have re-assessed the comments and I only have two more points:
1) The WriteOrbMoms seems like a "bad" option name.
2) I can make a PR for clarifying H_so in sparse_matrices. I think having the classes and names of the variables to coincide with the type to be good (H_so_on_2D, H_so_off_2D) for instance?