Code review comment for lp:~albertog/siesta/4.1-xc

Revision history for this message
Nick Papior (nickpapior) wrote :

Looks good to me!

1) You mention BSC may be "better" for GGA, I guess this means performance wise, no?

2) It is weird that forhar does not show any differences when using the "wrong" ordering? Why, it seems to suggest something is wrong! ? Or?

Lastly, a suggestion on the name of the XC.Use.BSC.CellXC name.

Could we perhaps make this more generalized so one can later use this to select distribution options?

I.e.

   XC.Distribution BSC|GridXC

or something else?

As far as I understand the only difference is the distribution of mesh-points? Correct me if I am wrong.

Great job!

review: Needs Information

« Back to merge proposal