Code review comment for lp:~albaguirre/unity8/add-screenshotter

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

> > * //TODO: This should be configurable (perhaps through gsettings?):
> > What's the use case/benefit for the user of making this configurable?
>
> Yeah, don't think we need to configure this. Why not PNG by default though?
>

I had it as PNG but other products do jpg too...presumably size?

> > * screenshotsDir.mkdir("Screenshots");
> > Should we localize this?
>
> No, we decided against localizing folder names because of having to
> "unlocalize" them everywhere that tries to read them.
>
> Is that folder be picked up by the gallery app already?

Yes it is.

« Back to merge proposal