Code review comment for lp:~albaguirre/unity8/add-screenshotter

Revision history for this message
Michael Zanetti (mzanetti) wrote :

Albert, the reason why this works is really because application surfaces are just normal QQuickItems inside the shell. It does only screenshot the shell window with whatever the shell paints, in this case also the application surface items. I think this is ok as it really only works inside the shell application but not from other apps etc.

But the other question I have is if we really want to have such a thing in the product. I imagine people hitting up + down accidentally all the time. Do we really want them to make screenshots without even knowing? This doesn't sound like being something I would want to have enabled in a final product. Instead I think this should be done properly through some ui element, maybe in the developer mode options.

review: Needs Information

« Back to merge proposal