Mir

Code review comment for lp:~albaguirre/mir/screencast-crash-fix

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

> 56 + if (type == GL_UNSIGNED_BYTE)
> 57 + read_pixel_format = static_cast<GLenum>(format);
>
> Better to use (type == GL_UNSIGNED_BYTE && format == GL_BGRA_EXT), for now at
> least, since we only support BGRA as an alternative, and platforms are allowed
> to return other types (e.g. GL_RGB). Of course, ideally we would support other
> types too.

Yeah, I just realize it could be another non 4-byte format. So then I'll do just the
glReadPixels as before but at setup time. See update.

« Back to merge proposal