Code review comment for lp:~albaguirre/mir/possibly-fix-yakkety-build-failure

Cemil Azizoglu (cemil-azizoglu) wrote :

1. We should remove #define _BSD_SOURCE" as silo might still fail when it encounters this. Or does that cause something else to fail?

2. you need to remove the other instance in progressbar.c.

3. Yet another instance is in src/CMakeLists.txt (which also has "_DEFAULT_SOURCE" defined).

review: Needs Fixing

« Back to merge proposal