Mir

Code review comment for lp:~albaguirre/mir/fix-1522105

  1. fix-1522105
  2. Merge into development-branch
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Clearly the "before" is worse than the proposal - it holds (and uses) a reference to an element that needs to be locked to avoid invalidation.

While there are no obvious problems with the proposed approach it isn't obvious that there are no problems. Maybe this is a case for RecursiveReadWriteMutex?

review: Needs Information

« Back to merge proposal