Mir

Code review comment for lp:~albaguirre/mir/fix-1499039

Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

Nits:

Seems to upset vivid builds. Because I don't think you mean this:

+ auto comp1{reinterpret_cast<mc::CompositorID>(0)};
+ auto comp2{reinterpret_cast<mc::CompositorID>(1)};

But

    auto const comp1 = reinterpret_cast<mc::CompositorID>(0);
    auto const comp2 = reinterpret_cast<mc::CompositorID>(1);

Using "auto" with initializer lists is a Bad Idea as it rarely does what you intend.

~~~~

+ mutable std::mutex guard;

cv-qualifiers should follow the type

review: Needs Fixing

« Back to merge proposal