Mir

Code review comment for lp:~albaguirre/mir/fix-1427976

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

Well after looking at bit more at the code, it seems like the real reason for the session_mutex unlock in the completion is to avoid holding a lock when invoking IPC callbacks.

Since Surface::swap_buffers may execute the completion within, we need to detect such condition and only unlock the session_mutex then instead of using a binary semaphore.

review: Disapprove

« Back to merge proposal