Code review comment for lp:~albaguirre/mir/bump-server-platforms-abi

> Yeah, it was a virtual method. That's an ABI break for the server graphics
> platform. Although not an ABI break to libmirserver (?).

Yes indeed it breaks both, we directly forward the interface defined for the server graphice platform abi to the users of mir server. So every bump there is in nearly every case a bump in mirserver.

A reasonable layer between platform and mir server is something we should work on soonish. Display/Group/Buffer/Configurations implementations have a lot of locks and for_each_methods that can easily interfere with whatever the compositor threads or input threads may want to do. And dead-lock as we have seen recently