Mir

Code review comment for lp:~albaguirre/mir/automate-abi-check

Revision history for this message
Alberto Aguirre (albaguirre) wrote :

> 343 +make -j${NUM_JOBS} abi-dump-base
>
> This will rebuild the archive version of mir. It's not too bad since we will
> not be building the tests, but it still is an overhead we can avoid.
>
> The alternative is to reuse the prebuilt archive packages. A way to do this
> is:
>
> 1. apt-get --print-uris --yes install libmirserver-dev libmirclient-dev ... |
> grep ^\' | cut -d\' -f > mir-archive.list
> 2. download each debian package in mir-archive.list (wget -i mir-archive.list)
> 3. Extract debian packages to some location (dpkg -x ... some/location)
> 4. MIR_ABI_DUMP_PREBUILT_LIBDIR=/some/location/usr/lib/$(dpkg-architecture
> -qDEB_HOST_MULTIARCH) debian/rules override_dh_auto_configure
> 5. make abi-dump-base
>
> Needs discussion

Yes I experimented with this a bit.

One issue is that you have to deal with the package cache - no uris will be printed if the package is already in your cache.

This shouldn't matter for a clean environment like in a CI job, but in a developer machine it could be an issue.

So a bit more intelligence is needed (figuring out the package names, some caching, looking into the existing package cache) - hence I went with the path of least resistance - apt-get source mir already downloads, caches and extracts, there's no package versions to figure out, etc.

I think it's doable but I guess I would consider that an additional optimization task that could be a separate MP.

« Back to merge proposal