Code review comment for lp:~albaguirre/indicator-power/use-new-brightness-dbus-interface

Revision history for this message
Iain Lane (laney) wrote :

Cheers. Since you asked me to review I've taken a look, but Charles I think usually takes care of i-power. One inline comment too.

The main problem is that you need to rename the 'powerd' references everywhere since that name is now inaccurate except for getBrightnessParams.

What provides this service? Please either add a dependency or (maybe this is a good idea anyway) keep the fallback to powerd if nothing has the new name.

review: Needs Fixing

« Back to merge proposal