Checkbox Provider - Base

Code review comment for ~alanec/plainbox-provider-checkbox:cpufreq_test-excp-fix

  1. Git
  2. lp:~alanec/plainbox-provider-checkbox
  3. cpufreq_test-excp-fix
  4. Merge into master
Revision history for this message
Jeff Lane  (bladernr) wrote :

Lets file a new bug to address Jonathan's concern. I don't disagree, but that would be out of scope for fixing this particular bug.

SO, Approve for this with the following conditions:

1: File a new bug to add a new resource job to create something like cpufreq.supported
2: Add an arg to the cpufreq script so that we can simply check that it is supported and if so, set cpufreq.supported to True.
3: modify the test job in P-P-C to require that resource == True.

review: Approve

« Back to merge proposal