Merge ~alanec/plainbox-provider-certification-server:rebase_lvm_precheck into plainbox-provider-certification-server:master

Proposed by Adrian Lane
Status: Merged
Approved by: Sylvain Pineau
Approved revision: 1cd0c23935d4d0414bf750bb360214882fdf1585
Merged at revision: bda9e1571c6c3315dfd0b6359f151140c9ea97ab
Proposed branch: ~alanec/plainbox-provider-certification-server:rebase_lvm_precheck
Merge into: plainbox-provider-certification-server:master
Diff against target: 37 lines (+18/-1)
1 file modified
tools/canonical-certification-precheck (+18/-1)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Jeff Lane  Pending
Review via email: mp+382785@code.launchpad.net

Commit message

Added add'l test to precheck script to detect and report LVM usage. lp: #1865487

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/tools/canonical-certification-precheck b/tools/canonical-certification-precheck
index 1be4f73..fd94e14 100755
--- a/tools/canonical-certification-precheck
+++ b/tools/canonical-certification-precheck
@@ -21,7 +21,7 @@ info(){
2121
2222
2323
24steps="Ubuntu_Version Arch EFI_Mode CCS_Version SID_Check Installed_Ram Virtualization_Support NICs_enabled Jumbo_Frames IPERF Network_Subnets Hard_Disks USB_Disks KVM_Image_Check LXD_Image_Check XDG_Check GPGPU_Check NVDIMM_Detection"24steps="Ubuntu_Version Arch EFI_Mode CCS_Version SID_Check Installed_Ram Virtualization_Support NICs_enabled Jumbo_Frames IPERF Network_Subnets LVM_Check Hard_Disks USB_Disks KVM_Image_Check LXD_Image_Check XDG_Check GPGPU_Check NVDIMM_Detection"
2525
26while getopts "i" opt; do26while getopts "i" opt; do
27 case $opt in27 case $opt in
@@ -171,6 +171,23 @@ if [ -d "/sys/bus/usb/devices" ]; then
171fi171fi
172}172}
173173
174LVM_Check(){
175name="LVM Check"
176echoname
177local lvmCount=$(sudo lvmdiskscan | awk '/[0-9] LVM/ {print $1}' | tr -d -c 0-9)
178local lvmList=($(sudo lvmdiskscan | awk '/] LVM/ {print $1}'))
179if [ "$lvmCount" -eq "0" ]; then
180 echo -e " LVM not present."
181 pass
182else
183 echo -e " LVM members found:"
184 for element in "${lvmList[@]}"; do
185 echo -e " ${element}"
186 done
187 fail
188fi
189}
190
174# Check for valid filesystem191# Check for valid filesystem
175Hard_Disks(){192Hard_Disks(){
176name="Hard Disk Filesystem Check"193name="Hard Disk Filesystem Check"

Subscribers

People subscribed via source and target branches