Provider for Plainbox - Canonical Certification Server

Merge ~alanec/plainbox-provider-certification-server:unit_test_changes-cpu into plainbox-provider-certification-server:master

  1. Git
  2. lp:~alanec/plainbox-provider-certification-server
  3. unit_test_changes-cpu
  4. Merge into master
Proposed by Adrian Lane
Status: Merged
Approved by: Jeff Lane 
Approved revision: c11f2373eb3e7eeff101d2662775518d081c5e24
Merged at revision: 2b58be646c490bebc27c1633ceed4658a0d42352
Proposed branch: ~alanec/plainbox-provider-certification-server:unit_test_changes-cpu
Merge into: plainbox-provider-certification-server:master
Diff against target: 126 lines (+9/-18)
9 files modified
units/server-full-16.04.pxu (+1/-2)
units/server-full-18.04.pxu (+1/-2)
units/server-functional-16.04.pxu (+1/-2)
units/server-functional-18.04.pxu (+1/-2)
units/server-regression-full.pxu (+1/-2)
units/server-soc-cert-16.04.pxu (+1/-2)
units/server-soc-cert-18.04.pxu (+1/-2)
units/virtual-machine-full-16.04.pxu (+1/-2)
units/virtual-machine-full-18.04.pxu (+1/-2)
Reviewer Review Type Date Requested Status
Jeff Lane  Approve
Review via email: mp+380269@code.launchpad.net

Commit message

Reset to HEAD~1 on plainbox-provider-checkbox and changed all refs in plainbox-provider-certification-server/units. lp: #:1866078

To post a comment you must log in.
Revision history for this message
Jeff Lane  (bladernr) wrote :

Just one question, did you run the script on a machine just to see what it does? (just because it's been forever since I last saw this run, I honestly don't remember what it looks like when it runs).

Otherwise LGTM

Revision history for this message
Adrian Lane (alanec) wrote :

Yep, put the servers and kernel-release details on the Trello card

> On Mar 5, 2020, at 10:06 AM, Jeff Lane <email address hidden> wrote:
>
> Just one question, did you run the script on a machine just to see what it does? (just because it's been forever since I last saw this run, I honestly don't remember what it looks like when it runs).
>
> Otherwise LGTM
> --
> https://code.launchpad.net/~alanec/plainbox-provider-certification-server/+git/plainbox-provider-certification-server/+merge/380269
> You are the owner of ~alanec/plainbox-provider-certification-server:unit_test_changes-cpu.

Revision history for this message
Adrian Lane (alanec) wrote :

Tested on saiph (hwe-18.04), mayapple (ga-18.04), persianlime (ga-18.04), plumcot (hwe-18.04), makrutlime (ga-20.04) successfully.

> On Mar 5, 2020, at 10:06 AM, Jeff Lane <email address hidden> wrote:
>
> Just one question, did you run the script on a machine just to see what it does? (just because it's been forever since I last saw this run, I honestly don't remember what it looks like when it runs).
>
> Otherwise LGTM
> --
> https://code.launchpad.net/~alanec/plainbox-provider-certification-server/+git/plainbox-provider-certification-server/+merge/380269
> You are the owner of ~alanec/plainbox-provider-certification-server:unit_test_changes-cpu.

Revision history for this message
Jeff Lane  (bladernr) wrote :

LTGM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/server-full-16.04.pxu b/units/server-full-16.04.pxu
2index db96372..856b836 100644
3--- a/units/server-full-16.04.pxu
4+++ b/units/server-full-16.04.pxu
5@@ -16,8 +16,7 @@ include:
6 benchmarks/disk/hdparm-read_.* certification-status=blocker
7 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
8 cpu/clocktest certification-status=blocker
9- cpu/scaling_test certification-status=blocker
10- cpu/scaling_test-log-attach certification-status=non-blocker
11+ cpu/frequency_governors certification-status=blocker
12 cpu/maxfreq_test certification-status=blocker
13 cpu/maxfreq_test-log-attach certification-status=non-blocker
14 cpu/topology certification-status=blocker
15diff --git a/units/server-full-18.04.pxu b/units/server-full-18.04.pxu
16index cbd89db..7340da5 100644
17--- a/units/server-full-18.04.pxu
18+++ b/units/server-full-18.04.pxu
19@@ -16,8 +16,7 @@ include:
20 benchmarks/disk/hdparm-read_.* certification-status=blocker
21 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
22 cpu/clocktest certification-status=blocker
23- cpu/scaling_test certification-status=blocker
24- cpu/scaling_test-log-attach certification-status=non-blocker
25+ cpu/frequency_governors certification-status=blocker
26 cpu/maxfreq_test certification-status=blocker
27 cpu/maxfreq_test-log-attach certification-status=non-blocker
28 cpu/topology certification-status=blocker
29diff --git a/units/server-functional-16.04.pxu b/units/server-functional-16.04.pxu
30index 2542a93..0a8d6bd 100644
31--- a/units/server-functional-16.04.pxu
32+++ b/units/server-functional-16.04.pxu
33@@ -16,8 +16,7 @@ include:
34 benchmarks/disk/hdparm-read_.* certification-status=blocker
35 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
36 cpu/clocktest certification-status=blocker
37- cpu/scaling_test certification-status=blocker
38- cpu/scaling_test-log-attach certification-status=non-blocker
39+ cpu/frequency_governors certification-status=blocker
40 cpu/maxfreq_test certification-status=blocker
41 cpu/maxfreq_test-log-attach certification-status=non-blocker
42 cpu/topology certification-status=blocker
43diff --git a/units/server-functional-18.04.pxu b/units/server-functional-18.04.pxu
44index e28376e..1b17e8c 100644
45--- a/units/server-functional-18.04.pxu
46+++ b/units/server-functional-18.04.pxu
47@@ -16,8 +16,7 @@ include:
48 benchmarks/disk/hdparm-read_.* certification-status=blocker
49 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
50 cpu/clocktest certification-status=blocker
51- cpu/scaling_test certification-status=blocker
52- cpu/scaling_test-log-attach certification-status=non-blocker
53+ cpu/frequency_governors certification-status=blocker
54 cpu/maxfreq_test certification-status=blocker
55 cpu/maxfreq_test-log-attach certification-status=non-blocker
56 cpu/topology certification-status=blocker
57diff --git a/units/server-regression-full.pxu b/units/server-regression-full.pxu
58index f80aa5e..3c69bde 100644
59--- a/units/server-regression-full.pxu
60+++ b/units/server-regression-full.pxu
61@@ -16,8 +16,7 @@ include:
62 benchmarks/disk/hdparm-read_.* certification-status=blocker
63 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
64 cpu/clocktest certification-status=blocker
65- cpu/scaling_test certification-status=blocker
66- cpu/scaling_test-log-attach certification-status=non-blocker
67+ cpu/frequency_governors certification-status=blocker
68 cpu/maxfreq_test certification-status=blocker
69 cpu/maxfreq_test-log-attach certification-status=non-blocker
70 cpu/topology certification-status=blocker
71diff --git a/units/server-soc-cert-16.04.pxu b/units/server-soc-cert-16.04.pxu
72index 6bfb5f9..3fb4708 100644
73--- a/units/server-soc-cert-16.04.pxu
74+++ b/units/server-soc-cert-16.04.pxu
75@@ -15,8 +15,7 @@ include:
76 benchmarks/disk/hdparm-read_.*
77 benchmarks/disk/hdparm-cache-read_.*
78 cpu/clocktest certification-status=blocker
79- cpu/scaling_test certification-status=blocker
80- cpu/scaling_test-log-attach certification-status=non-blocker
81+ cpu/frequency_governors certification-status=blocker
82 cpu/maxfreq_test certification-status=blocker
83 cpu/maxfreq_test-log-attach certification-status=non-blocker
84 cpu/topology certification-status=blocker
85diff --git a/units/server-soc-cert-18.04.pxu b/units/server-soc-cert-18.04.pxu
86index fdbf8aa..834f118 100644
87--- a/units/server-soc-cert-18.04.pxu
88+++ b/units/server-soc-cert-18.04.pxu
89@@ -15,8 +15,7 @@ include:
90 benchmarks/disk/hdparm-read_.*
91 benchmarks/disk/hdparm-cache-read_.*
92 cpu/clocktest certification-status=blocker
93- cpu/scaling_test certification-status=blocker
94- cpu/scaling_test-log-attach certification-status=non-blocker
95+ cpu/frequency_governors certification-status=blocker
96 cpu/maxfreq_test certification-status=blocker
97 cpu/maxfreq_test-log-attach certification-status=non-blocker
98 cpu/topology certification-status=blocker
99diff --git a/units/virtual-machine-full-16.04.pxu b/units/virtual-machine-full-16.04.pxu
100index 643ba7c..bdc3c09 100644
101--- a/units/virtual-machine-full-16.04.pxu
102+++ b/units/virtual-machine-full-16.04.pxu
103@@ -16,8 +16,7 @@ include:
104 benchmarks/disk/hdparm-read_.* certification-status=blocker
105 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
106 cpu/clocktest certification-status=blocker
107- cpu/scaling_test certification-status=blocker
108- cpu/scaling_test-log-attach certification-status=non-blocker
109+ cpu/frequency_governors certification-status=blocker
110 cpu/maxfreq_test certification-status=blocker
111 cpu/maxfreq_test-log-attach certification-status=non-blocker
112 cpu/topology certification-status=blocker
113diff --git a/units/virtual-machine-full-18.04.pxu b/units/virtual-machine-full-18.04.pxu
114index 88d3952..a624b7e 100644
115--- a/units/virtual-machine-full-18.04.pxu
116+++ b/units/virtual-machine-full-18.04.pxu
117@@ -16,8 +16,7 @@ include:
118 benchmarks/disk/hdparm-read_.* certification-status=blocker
119 benchmarks/disk/hdparm-cache-read_.* certification-status=blocker
120 cpu/clocktest certification-status=blocker
121- cpu/scaling_test certification-status=blocker
122- cpu/scaling_test-log-attach certification-status=non-blocker
123+ cpu/frequency_governors certification-status=blocker
124 cpu/maxfreq_test certification-status=blocker
125 cpu/maxfreq_test-log-attach certification-status=non-blocker
126 cpu/topology certification-status=blocker

Subscribers

People subscribed via source and target branches