Merge lp:~alan-griffiths/unity-mir/dont-use-SessionManager into lp:unity-mir

Proposed by Alan Griffiths
Status: Merged
Approved by: Gerry Boland
Approved revision: 138
Merged at revision: 138
Proposed branch: lp:~alan-griffiths/unity-mir/dont-use-SessionManager
Merge into: lp:unity-mir
Diff against target: 51 lines (+4/-6)
3 files modified
src/unity-mir/sessionauthorizer.cpp (+1/-2)
src/unity-mir/sessionauthorizer.h (+1/-2)
src/unity-mir/shellserverconfiguration.cpp (+2/-2)
To merge this branch: bzr merge lp:~alan-griffiths/unity-mir/dont-use-SessionManager
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+193032@code.launchpad.net

Commit message

Remove dependency on mir::shell::SessionManager

Description of the change

Remove dependency on mir::shell::SessionManager

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gerry Boland (gerboland) wrote :

Approved, thank you

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/unity-mir/sessionauthorizer.cpp'
--- src/unity-mir/sessionauthorizer.cpp 2013-08-15 15:15:10 +0000
+++ src/unity-mir/sessionauthorizer.cpp 2013-10-29 10:19:25 +0000
@@ -17,10 +17,9 @@
17#include "sessionauthorizer.h"17#include "sessionauthorizer.h"
18#include "logging.h"18#include "logging.h"
1919
20SessionAuthorizer::SessionAuthorizer(std::shared_ptr<mir::shell::SessionManager> const& sessionManager, QObject *parent)20SessionAuthorizer::SessionAuthorizer(QObject *parent)
21 : QObject(parent)21 : QObject(parent)
22{22{
23 Q_UNUSED(sessionManager)
24}23}
2524
26SessionAuthorizer::~SessionAuthorizer()25SessionAuthorizer::~SessionAuthorizer()
2726
=== modified file 'src/unity-mir/sessionauthorizer.h'
--- src/unity-mir/sessionauthorizer.h 2013-09-26 09:48:22 +0000
+++ src/unity-mir/sessionauthorizer.h 2013-10-29 10:19:25 +0000
@@ -22,7 +22,6 @@
2222
23// mir23// mir
24#include <mir/frontend/session_authorizer.h>24#include <mir/frontend/session_authorizer.h>
25#include <mir/shell/session_manager.h>
2625
27// Qt26// Qt
28#include <QObject>27#include <QObject>
@@ -32,7 +31,7 @@
32 Q_OBJECT31 Q_OBJECT
3332
34public:33public:
35 SessionAuthorizer(std::shared_ptr<mir::shell::SessionManager> const& sessionManager, QObject *parent = 0);34 SessionAuthorizer(QObject *parent = 0);
36 ~SessionAuthorizer();35 ~SessionAuthorizer();
3736
38 virtual bool connection_is_allowed(pid_t pid) override;37 virtual bool connection_is_allowed(pid_t pid) override;
3938
=== modified file 'src/unity-mir/shellserverconfiguration.cpp'
--- src/unity-mir/shellserverconfiguration.cpp 2013-10-17 10:30:33 +0000
+++ src/unity-mir/shellserverconfiguration.cpp 2013-10-29 10:19:25 +0000
@@ -86,9 +86,9 @@
86ShellServerConfiguration::the_session_authorizer()86ShellServerConfiguration::the_session_authorizer()
87{87{
88 return session_authorizer(88 return session_authorizer(
89 [this]()89 []
90 {90 {
91 return std::make_shared<SessionAuthorizer>(the_session_manager());91 return std::make_shared<SessionAuthorizer>();
92 });92 });
93}93}
9494

Subscribers

People subscribed via source and target branches