Code review comment for lp:~alan-griffiths/unity-mir/dont-use-OrganisingSurfaceFactory

Hang on, changed my mind about something.

+SurfaceSource::SurfaceSource(std::shared_ptr<mir::shell::SurfaceFactory> const& surfaceFactory,
In Mir, mir::shell::SurfaceSource is the implementation of the pure virtual class mir::surface::SurfaceFactory.

With this MR, Unity-mir now implements mir::surface::SurfaceFactory, instead of mir::shell::SurfaceSource. I'd like to maintain the pattern that the implementation is named after the class it inherits, when possible.

I'd prefer you rename the class SurfaceSource to SurfaceFactory here. Also I find the purpose of a class named "Factory" much more obvious than "Source" anyway, so I think it would be a readability win.

That does break the parallelism of naming with Mir however.