Code review comment for lp:~alan-griffiths/unity-mir/dont-use-ApplicationSession

Revision history for this message
Gerry Boland (gerboland) wrote :

Missed stuff:

src/unity-mir/sessionlistener.cpp:
qRegisterMetaType<std::shared_ptr<msh::Session>>("std::shared_ptr<mir::shell::ApplicationSession>");
would be best to keep the Qt Metatype name matching the actual type.

src/modules/Unity/Application/application_manager.h:
you could remove the "class ApplicationSession;" here too. I don't see it being referred to anywhere.

review: Needs Fixing

« Back to merge proposal